Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improved UI] The UI for Preview is improved #1106

Closed
lllyasviel opened this issue May 1, 2023 · 5 comments
Closed

[Improved UI] The UI for Preview is improved #1106

lllyasviel opened this issue May 1, 2023 · 5 comments

Comments

@lllyasviel
Copy link
Collaborator

image

Now it looks like this.

You may notice that the preview now have "Close" button, and if you use Openpose, you can download pose meta with "Json" button.

Also, since many users say that they cannot find "trigger"💥 icon, now the trigger icon is always visible. Also since we have "Close" button, users may less likely to get trouble if they just want to close it (even if they do not know to uncheck "allow preview")

Much more user-friendly.

Note that such complicated javascript to hack gradio is super difficult, and I do not know how to implement such complicated js hack.

The hacking code is written by CHATGPT

but I have stolen some basics from huchenlei

@stephenlacy
Copy link

The "trigger" icon was very unintuitive to figure out and use. Since it's between two select dropdowns it does not indicated "Preview" or "Run".
I'd request a "Run" or "Preview" button instead.

@huchenlei
Copy link
Collaborator

The "trigger" icon was very unintuitive to figure out and use. Since it's between two select dropdowns it does not indicated "Preview" or "Run". I'd request a "Run" or "Preview" button instead.

If you hover on the trigger button it will show a hint "Run preprocessor".

@stephenlacy
Copy link

Not looking for hints -- UI should be intuitive not a search for missing buttons

@lllyasviel
Copy link
Collaborator Author

image

@stephenlacy
Copy link

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants