Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X64] [MichalPetryka] Improve updating classes for generics #167

Open
MihuBot opened this issue Aug 28, 2023 · 1 comment
Open

[X64] [MichalPetryka] Improve updating classes for generics #167

MihuBot opened this issue Aug 28, 2023 · 1 comment

Comments

@MihuBot
Copy link
Owner

MihuBot commented Aug 28, 2023

Build completed in 1 hour 30 minutes.
dotnet/runtime#88277

CoreLib diffs

Found 2 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 7135594
Total bytes of diff: 7135594
Total bytes of delta: 0 (0.00 % of base)


0 total files with Code Size differences (0 improved, 0 regressed), 1 unchanged.

0 total methods with Code Size differences (0 improved, 0 regressed), 52963 unchanged.

--------------------------------------------------------------------------------

Frameworks diffs

Diffs
Found 311 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 38861130
Total bytes of diff: 38861129
Total bytes of delta: -1 (-0.00 % of base)
Total relative delta: -0.01
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
          -1 : System.Threading.Tasks.Dataflow.dasm (-0.00 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 255 unchanged.

Top method regressions (bytes):
           1 (0.24 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1[System.__Canon]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)

Top method improvements (bytes):
          -1 (-0.88 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1[System.__Canon]:System.Collections.IStructuralEquatable.GetHashCode(System.Collections.IEqualityComparer):int:this (FullOpts)
          -1 (-0.26 % of base) : System.Threading.Tasks.Dataflow.dasm - System.Threading.Tasks.Dataflow.BatchBlock`1+BatchBlockTargetCore[System.__Canon]:get_DebuggerDisplayContent():System.Object:this (FullOpts)

Top method regressions (percentages):
           1 (0.24 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1[System.__Canon]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)

Top method improvements (percentages):
          -1 (-0.88 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1[System.__Canon]:System.Collections.IStructuralEquatable.GetHashCode(System.Collections.IEqualityComparer):int:this (FullOpts)
          -1 (-0.26 % of base) : System.Threading.Tasks.Dataflow.dasm - System.Threading.Tasks.Dataflow.BatchBlock`1+BatchBlockTargetCore[System.__Canon]:get_DebuggerDisplayContent():System.Object:this (FullOpts)

3 total methods with Code Size differences (2 improved, 1 regressed), 233748 unchanged.

--------------------------------------------------------------------------------

Artifacts:

@MihuBot
Copy link
Owner Author

MihuBot commented Aug 28, 2023

@JulieLeeMSFT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant