Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MichalPetryka] [X64] Improve updating classes for generics #108

Open
MihuBot opened this issue Jul 7, 2023 · 1 comment
Open

[MichalPetryka] [X64] Improve updating classes for generics #108

MihuBot opened this issue Jul 7, 2023 · 1 comment

Comments

@MihuBot
Copy link
Owner

MihuBot commented Jul 7, 2023

Build completed in 1 hour 6 minutes.
dotnet/runtime#88277

CoreLib diffs

Found 2 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 6514213
Total bytes of diff: 6514213
Total bytes of delta: 0 (0.00 % of base)


0 total files with Code Size differences (0 improved, 0 regressed), 1 unchanged.

0 total methods with Code Size differences (0 improved, 0 regressed), 52370 unchanged.

--------------------------------------------------------------------------------

Frameworks diffs

Diffs
Found 298 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 37900367
Total bytes of diff: 37900366
Total bytes of delta: -1 (-0.00 % of base)
Total relative delta: -1.01
    diff is an improvement.
    relative diff is an improvement.


Total byte diff includes 5 bytes from reconciling methods
	Base had    0 unique methods,        0 unique bytes
	Diff had    1 unique methods,        5 unique bytes

Top file improvements (bytes):
          -1 : System.Threading.Tasks.Dataflow.dasm (-0.00 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 254 unchanged.

Top method regressions (bytes):
           5 (Infinity of base) : System.DirectoryServices.Protocols.dasm - 
           1 (0.23 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1[System.__Canon]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)

Top method improvements (bytes):
          -5 (-100.00 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.LdapConnection:get_Timeout():System.TimeSpan:this (FullOpts)
          -1 (-0.88 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1[System.__Canon]:System.Collections.IStructuralEquatable.GetHashCode(System.Collections.IEqualityComparer):int:this (FullOpts)
          -1 (-0.26 % of base) : System.Threading.Tasks.Dataflow.dasm - System.Threading.Tasks.Dataflow.BatchBlock`1+BatchBlockTargetCore[System.__Canon]:get_DebuggerDisplayContent():System.Object:this (FullOpts)

Top method regressions (percentages):
           5 (Infinity of base) : System.DirectoryServices.Protocols.dasm - 
           1 (0.23 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1[System.__Canon]:System.Collections.IStructuralComparable.CompareTo(System.Object,System.Collections.IComparer):int:this (FullOpts)

Top method improvements (percentages):
          -5 (-100.00 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.LdapConnection:get_Timeout():System.TimeSpan:this (FullOpts)
          -1 (-0.88 % of base) : System.Collections.Immutable.dasm - System.Collections.Immutable.ImmutableArray`1[System.__Canon]:System.Collections.IStructuralEquatable.GetHashCode(System.Collections.IEqualityComparer):int:this (FullOpts)
          -1 (-0.26 % of base) : System.Threading.Tasks.Dataflow.dasm - System.Threading.Tasks.Dataflow.BatchBlock`1+BatchBlockTargetCore[System.__Canon]:get_DebuggerDisplayContent():System.Object:this (FullOpts)

5 total methods with Code Size differences (3 improved, 2 regressed), 232177 unchanged.

--------------------------------------------------------------------------------

Artifacts:

@MihuBot
Copy link
Owner Author

MihuBot commented Jul 7, 2023

@MichalPetryka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant