Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove title and icon fields #278

Closed
connor-moody opened this issue Apr 8, 2020 · 1 comment · Fixed by #282
Closed

Remove title and icon fields #278

connor-moody opened this issue Apr 8, 2020 · 1 comment · Fixed by #282
Assignees
Labels
URLProtocolHandler Label used for artifacts related to the URL Protocol Handler explainer.

Comments

@connor-moody
Copy link
Contributor

connor-moody commented Apr 8, 2020

This whatwg/HTML PR proposes simplifying registerProtocolHandler() by removing the title argument. To ensure that declarative protocol_handlers in PWA manifests and the registerProtocolHandlers() API are as aligned as closely as possible, the title field and the related icon field should be removed from this proposal.

@connor-moody connor-moody added the URLProtocolHandler Label used for artifacts related to the URL Protocol Handler explainer. label Apr 8, 2020
@fabiorocha
Copy link
Member

I agree with the consensus of removing the title and icon members from the proposal. It should be easy to have them proposed to a later iteration if there's a strong enough need backed up by data.

I'll put up a PR shortly to remove those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
URLProtocolHandler Label used for artifacts related to the URL Protocol Handler explainer.
Projects
None yet
4 participants