Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy support setting removes GET query parameters from URLs on extension's GET requests #66892

Closed
SounD120 opened this issue Jan 22, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug proxy Issues regarding network proxies verified Verification succeeded

Comments

@SounD120
Copy link

SounD120 commented Jan 22, 2019

  • VSCode Version: 1.30.2 - 1.31-insiders
  • OS Version: Windows 10 (1803), macOS 10.14.2 Mojave

Steps to Reproduce:

  1. Clone test VS Code extension with git clone https://github.com/SounD120/proxysupporttest.git command
  2. cd proxysupporttest
  3. npm i
  4. code .
  5. Open VS Code Preferences->Settings, find and enable Proxy Support setting with on or override option.
  6. Open debug tab and run Run extension
  7. In Extension Developement Host call command pallete and run Proxy Support Test: Start test HTTP server command
  8. Call Proxy Support Test: Send HTTP request to server command from command pallete

You will see the VS Code information message window with URL which hit the server.

In my test repo I used such URL : http://127.0.0.1:8080?platform=android

Without Proxy Support setting HTTP get request returns : /?platform=android
With Proxy Support setting HTTP get request returns: /

Also this setting is enabled in 1.31-insiders by default, so I want to clarify would it be enabled in release 1.31 version?

Observation: this might be connected to this code

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Jan 22, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Jan 22, 2019
@sandy081 sandy081 removed the extensions Issues concerning extensions label Jan 22, 2019
@SounD120 SounD120 changed the title Proxy support setting removes GET part from URLs on extension's GET requests Proxy support setting removes GET query parameter from URLs on extension's GET requests Jan 24, 2019
@SounD120 SounD120 changed the title Proxy support setting removes GET query parameter from URLs on extension's GET requests Proxy support setting removes GET query parameters from URLs on extension's GET requests Jan 24, 2019
@chrmarti chrmarti added this to the December/January 2019 milestone Jan 27, 2019
@chrmarti
Copy link
Collaborator

@SounD120 Thanks for the detailed bug report!

The setting will be enabled as 'override' in the upcoming release.

@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug proxy Issues regarding network proxies labels Jan 28, 2019
@dbaeumer dbaeumer added the verified Verification succeeded label Feb 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug proxy Issues regarding network proxies verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants