Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace workbench.customDebugRequest command usages with official API #41945

Closed
roblourens opened this issue Jan 22, 2018 · 3 comments
Closed

Replace workbench.customDebugRequest command usages with official API #41945

roblourens opened this issue Jan 22, 2018 · 3 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
January 2018

Comments

@roblourens
Copy link
Member

  • Run Chrome or Node debugging
  • Use the "Toggle skipping this file" command from the call stack
  • See Error: command 'workbench.customDebugRequest' not found error in the devtools console

I will switch to the official API, but node, node2, and Chrome still reference this so was it supposed to be removed?

cc @weinand
@roblourens roblourens added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jan 22, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 22, 2018 •
edited
Loading

@roblourens yes this command was removed as specified 2 milestones ago in the release notes https://code.visualstudio.com/updates/v1_18#_debug-api-updates

Since no other debug author complained for 3 months I suggest that you simply update the node and chrome adapters to use the customRequest

I have also checked the top 100 extensions and no extension is using this command.
Only found 3 usages and created issues for them (not popular extensions).
microsoft/vscode-edge-debug2#1
Kode/vscode-krom-debug#2
karikera/vscode-nwjs-debug#16

@isidorn isidorn closed this as completed Jan 22, 2018
@roblourens
Copy link
Member Author

Sure. Will keep this issue to do that.

@roblourens roblourens reopened this Jan 22, 2018
@roblourens roblourens assigned roblourens and unassigned isidorn Jan 22, 2018
@roblourens roblourens added this to the January 2018 milestone Jan 22, 2018
@roblourens
Copy link
Member Author

roblourens commented Jan 24, 2018 •
edited
Loading

Fixed in node, node2, chrome

@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Jan 24, 2018
@weinand weinand added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
3 participants
@roblourens @weinand @isidorn