-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextFileEditorModelManager disposes models it doesn't own #17888
Labels
Milestone
Comments
The is some
model.onDispose(() => {
const {stack} = new Error();
console.warn('DISPOSING MODEL FOR ' + this.uri);
console.warn(stack);
});
|
jrieken
changed the title
References are shown as blank if the tab width is too small
TextFileEditorModelManager disposes models it doesn't own
Feb 10, 2017
Needs #17073 for file models. |
This was referenced Feb 24, 2017
And actually blocked by #21709 |
Fixed via 5ecf0cd |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Steps to Reproduce:
closeEditor
, click Find all referencesCmd+Click
on references ineditorService
, the file containing that reference will be opened on the right side editor group.Gif demonstrating the steps:
It's not that easy to reproduce, you might need to run step 4 several times.
The text was updated successfully, but these errors were encountered: