Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Look at breaking on rejected Promise #46

Closed
roblourens opened this issue Oct 24, 2016 · 2 comments
Closed

Look at breaking on rejected Promise #46

roblourens opened this issue Oct 24, 2016 · 2 comments

Comments

@roblourens
Copy link
Member

microsoft/vscode#1746 (comment)
@roblourens roblourens mentioned this issue Feb 15, 2017
Closed
@roblourens
Copy link
Member Author

If a promise is rejected before an error handler is attached, the debugger will break, even if only "uncaught exceptions" is checked. If it's rejected after the error handler is attached, it works as expected. The pause event has a reason "promise rejection", so we could implement this as a third exception checkbox if we wanted, but I think that's unexpected and confusing. And really the problem is the way the promise doesn't know whether its rejection will be handled or not.

@roblourens
Copy link
Member Author

I did fix the pause reason though

roblourens added a commit to microsoft/vscode-chrome-debug-core that referenced this issue Mar 2, 2017
@roblourens
Fix promise rejection pause reason - related to microsoft/vscode-node…
03e83a4 
…-debug2#46
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roblourens