Include typings from subdirectories #11
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an
.npmignore
entry that prevents some typing information from being published.Rational:
vscode-yaml-languageservice (powers vscode-yaml) reuses the AST representation from this library to build an AST from a YAML document, and it feeds that representation to services from this library to gain most of the validation and other goodies from this library.
To overcome the lack of published type definitions, vscode-yaml-languageservice used
git submodule
to depend directly on the source code from this repository. While this worked it was inconvenient and fragile (broken by changes innpm
behavior).I would really like a better story for managing the vscode-json-languageservice dependency that could preferably use
npm
like usual. This is the easiest solution, requiring the least additional management I have come up with. I recognize that, even if type information is published, vscode-yaml-languageservices is depending on "internal" APIs and breaking changes could occur at any time.(This has been sparked somewhat by an increased interest in the YAML support provided by vscode-yaml [on private channels] and possibly wanting to use the service to add support in other editors).