This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Add Bazel support for gocodePackageLookupMode #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Option was introduced here: nsf/gocode@725b543
ramya-rao-a
suggested changes
Oct 10, 2018
There was a problem hiding this comment.
Thanks for your patience @bweston92!
Can you also update the description of the gocodePackageLookupMode setting to include a note on bzl?
Also include a note that this setting only applies when using nsf/gocode and not the currently used forks of gocode.
|
By the way, if you are interested in winning a t-shirt in the hactoberfest, close this PR and open a new one :). See https://open.microsoft.com/2018/09/18/hacktoberfest-2018-microsoft/?WT.mc_id=hacktoberfest-twitter-beverst for more details |
ramya-rao-a
approved these changes
Oct 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option was introduced here: nsf/gocode@725b543