-
Notifications
You must be signed in to change notification settings - Fork 645
new: support for showing coverage on single function test. closes #1637 #1638
new: support for showing coverage on single function test. closes #1637 #1638
Conversation
hum the test failed, on go tip, and I don't think really understand how it would be related to my changes :/ |
@primalmotion the ci log shows that the linter failed: https://travis-ci.org/Microsoft/vscode-go/jobs/368922868#L877 Run the TS linter on the files you changed and try again You can install it here: https://marketplace.visualstudio.com/items?itemName=eg2.tslint |
Subtle :) I’ll fix it asap |
lint is fixed, but tests are failing on go:tip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wary on re-using the setting coverOnTestPackage
for this purpose.
coverOnTestPackage
setting is true
by default. So when people run all tests in a package, all related code files get coverage. Which makes sense, because all applicable tests are run and the coverage is shown.
If we re-use this setting, then when users run individual tests, then the coverage will show up by default, probably highlighting most of the code in red (assuming the single test was covering a very small portion of the complete code)
Also, the same wont happen when the user runs all tests in current file. So there is an inconsistency.
I would suggest to add a new setting instead coverOnSingleTest
and keep it false by default.
Sure I can add a new parameter. |
@ramya-rao-a added requested changes |
Thanks! |
Thanks! |
I took a shot at implementing #1637.