Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Add support for "Go to Type Definition"/"Peek Type Definition" #2121

Closed
segevfiner opened this issue Nov 13, 2018 · 5 comments
Closed

Add support for "Go to Type Definition"/"Peek Type Definition" #2121

segevfiner opened this issue Nov 13, 2018 · 5 comments

Comments

@segevfiner
Copy link
Contributor

Implement TypeDefinitionProvider which would add support for "Go to Type Definition" and "Peek Type Definition". This would be really helpful for Go, which uses type inference a lot, so you rarely have a type to click on for "Go to Definition"/"Peek Definition".

@ramya-rao-a
Copy link
Contributor

Doesnt the existing Go to Implementation command help do the same? It uses guru implements.

@segevfiner
Copy link
Contributor Author

Doesnt the existing Go to Implementation command help do the same? It uses guru implements.

I think the "Go to Implementation" command as implemented will go to the implementation of an interface/method. If you use it on a variable it will just fail.

What is asked here is being able to go to the definition of the type of the symbol under the cursor. Go to Type Definition on a struct variable should go to where that struct type is defined.

@ramya-rao-a
Copy link
Contributor

Got it, thanks!

@segevfiner
Copy link
Contributor Author

#2136 was merged. I guess this can be closed.

@ramya-rao-a
Copy link
Contributor

This feature is now available in the latest version of the Go extension (0.8.0)
Thanks @hummerd!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants