Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network option to Docker run configuration #748

Merged
merged 3 commits into from
Jan 18, 2019

Conversation

philliphoff
Copy link
Member

Adds a network option to the Docker run section of the Docker debug configuration. This option corresponds to the --network option of the docker run command.

Also resolves an issue introduced with #690 which causes debugging to fail if the volumes configuration option is not specified (i.e. is undefined). (In that case, the workaround until this fix is committed and released is to set it to an empty array.)

@philliphoff philliphoff requested a review from a team as a code owner January 18, 2019 00:21
@philliphoff
Copy link
Member Author

Resolves #692.

@philliphoff philliphoff merged commit 3153a32 into master Jan 18, 2019
@philliphoff philliphoff deleted the philliphoff-network branch January 18, 2019 17:31
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants