Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__CODE__ gets rendered as bold in hover doc comments #3441

Closed
sean-mcmanus opened this issue Apr 9, 2019 · 0 comments
Closed

__CODE__ gets rendered as bold in hover doc comments #3441

sean-mcmanus opened this issue Apr 9, 2019 · 0 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone
April 2019

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Apr 9, 2019 •
edited
Loading

We send the hover doc comments to VS Code as "markup", causing stuff like __CODE__ to render as bold (CODE).

I remember wanting to send the hover doc comments as plain text, but I think Bob wanted it to not be fixed width like VS -- so maybe we just need to escape the special markup stuff -- not sure what other cases we're missing though that also need to be escaped.
@sean-mcmanus sean-mcmanus added this to the April 2019 milestone Apr 10, 2019
@sean-mcmanus sean-mcmanus added fixed Check the Milestone for the release in which the fix is or will be available. quick fix labels Apr 10, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
None yet
Milestone
April 2019
Development

No branches or pull requests
1 participant
@sean-mcmanus