Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive includes don't add paths used by forcedInclude files #2986

Closed
sean-mcmanus opened this issue Jan 1, 2019 · 5 comments
Closed

Recursive includes don't add paths used by forcedInclude files #2986

sean-mcmanus opened this issue Jan 1, 2019 · 5 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jan 1, 2019

Use a forcedInclude file that has a #include to a non-local file that is under a recursive include, e.g. if the includePath is "${workspaceFolder}/**", then the forcedInclude could use "#include <subfolder/file.h>".

Bug: The subfolder is incorrectly not getting added to the includePath for IntelliSense.

This was initially reported in bug #2610 .

@sean-mcmanus sean-mcmanus added this to the Triage milestone Jan 1, 2019
@sean-mcmanus sean-mcmanus changed the title Recursive includes doens't add paths used by forcedInclude files Recursive includes don't add paths used by forcedInclude files Jan 1, 2019
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jan 1, 2019
@sean-mcmanus sean-mcmanus modified the milestones: Triage, December 2018 Jan 1, 2019
@sean-mcmanus
Copy link
Contributor Author

Fixed with our latest 0.21.0-insiders3. Setting C_Cpp.updateChannel to "Insiders" is another way to get the update.

@JJChasel
Copy link

Fixed with our latest 0.21.0-insiders3. Setting C_Cpp.updateChannel to "Insiders" is another way to get the update.

Does this merge in the latest win32 release? I download it but this issue still exist as follow

  • Folder Structure:
  • proj
    • someheader.h
    • core
      • src
        • test.c
      • inc
        • test.h

and where

// test.c
#include "inc/test.h"
// codes

When NOT force include someheader.h, it works will. After add forced include to the config file, it can't found test.h

@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Jan 10, 2019

@JJChasel Thanks a lot for reporting this -- your repro is different from this bug's, but it's a regression, seemingly caused by the fix for this bug -- we'll try to fix it for 0.21.0.

@sean-mcmanus
Copy link
Contributor Author

@JJChasel Update -- the bug you reported has been fixed for our next release...expected "soon".

@sean-mcmanus
Copy link
Contributor Author

@JJChasel The bug you found with 0.21.0-insiders3 should be fixed now with 0.21.0.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
None yet
Development

No branches or pull requests

2 participants