Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Configure your IntelliSense settings to help find missing headers." not super helpful #2408

Closed
marcoscaceres opened this issue Aug 16, 2018 · 6 comments
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Milestone

Comments

@marcoscaceres
Copy link

When the error for "Configure your IntelliSense settings to help find missing headers." comes up, it doesn't actually tell you where to go and add/fix the configuration file. This means spending a bunch of time Googling what to actually do.

Could you please add some instructions as to where to click? Or provide some kind of link that goes straight to the the right settings/place?

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Aug 16, 2018

Yeah, I think we could add a button to message box to open the settings, like we do with the code action on the green squiggles with "#include errors detected".

image

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Aug 16, 2018

Actually -- we already do show a Learn More button.

image

Which sends users to
https://github.com/Microsoft/vscode-cpptools/blob/master/Documentation/Getting%20started%20with%20IntelliSense%20configuration.md

Is this not sufficient for some reason? We could also auto-open the c_cpp_properties.json for the user.

@sean-mcmanus sean-mcmanus added more info needed The issue report is not actionable in its current state by design Feature Request quick fix and removed Feature Request quick fix labels Aug 16, 2018
@marcoscaceres
Copy link
Author

marcoscaceres commented Aug 16, 2018

I did eventually click “Learn more”, but it was unclear that learn more was not about the extension. Maybe the button can be renamed?

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Aug 16, 2018

VS Code added "Source: C/C++ (Extension)" to the UI, which didn't used to be there, which sort of makes the "Learn More" look like it applies to the extension generally instead of the specific message.

We could change it to "Configuration Help": #2410 -- it's possible other people on our team might disagree though (I'll see).

@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Aug 16, 2018
@sean-mcmanus sean-mcmanus added this to the August 2018 milestone Aug 16, 2018
@sean-mcmanus sean-mcmanus removed by design more info needed The issue report is not actionable in its current state labels Aug 16, 2018
@marcoscaceres
Copy link
Author

"Configuration Help" sounds great.

@sean-mcmanus
Copy link
Contributor

Fixed with 0.18.0.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
None yet
Development

No branches or pull requests

2 participants