"Discovering files" icon not responsive to theme

[james-b-yu]

After enjoying the extension for several months now, I have noticed that the "Discovering files" icon in the right-hand side of the status bar does not respond to the theme. This makes it virtually useless in light themes when it becomes virtually invisible.

The icon is indeed there as it is hoverable -- the tooltip is still displayed on mouse-over.

The icon is of course fully visible in a dark theme:

This looks very unprofessional but the fix shouldn't be too difficult as VSCode is already aware of which themes are dark and which are light:

As an alternative, an actual progress bar or text display which shows the progress and extent of files indexed/to be indexed could be implemented.

[bobbrow]

I didn't realize we were setting a color for this icon. In any case it looks like VSCode has opened up the statusbar item API to allow for us to link these icons to the theme colors. Should be an easy fix. Thanks for the report.

[sean-mcmanus]

Yeah, we had discussions about this previously -- it was decided to hardcode the colors to the red flame and the white database icon, but I didn't realize a theme had a white status bar. We should probably change this to statusBar.foreground (see https://code.visualstudio.com/docs/getstarted/theme-color-reference ). Not sure if there's any themes with a red status bar we need to handle.

[sean-mcmanus]

Should be fixed with 0.16.1.