Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Darwin) Exclude Xcode and /usr/include symbols from Workspace Symbols Search #1119

Closed
loganintech opened this issue Oct 9, 2017 · 9 comments
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Milestone

Comments

@loganintech
Copy link

loganintech commented Oct 9, 2017

Maybe I just can't find it, but when using workspace symbols search, it seems like there should be an option to exclude Xcode and /usr/include symbols.

This is what happens when I search for workspace symbols now:

It's not useful to me to have 99% of the results be constants or parts defined from other places.

@loganintech
Copy link
Author

Any update on this?

@bobbrow
Copy link
Member

bobbrow commented Dec 7, 2017

I'm sorry, we don't have an update for you on this. Just checking though... do you really want to exclude all of the standard libraries from your symbol search? Or maybe just move them down in the list?

@loganintech
Copy link
Author

I suppose it depends on the context. The optimal would probably be to put them at the end of the list, but most of the time I'm writing pure C I don't need all of apple's default C libraries. Just my two cents. I'm betting at the end of the day having an option to move them or exclude them couldn't be too difficult. I'm sad this extension is closed source.

@loganintech
Copy link
Author

Didn't mean to close, my mistake.

@sean-mcmanus
Copy link
Contributor

Have you tried removing the paths you don't want from browse.path?

@loganintech
Copy link
Author

@sean-mcmanus I had not, but I just did yielding the same results.

@sean-mcmanus
Copy link
Contributor

@HazardDev Oh, I think this is a bug. I hit this issue on November 3rd on Linux where I would remove all the paths, but it was still picking up stdio.h somehow. I'll investigate for our January release.

@sean-mcmanus sean-mcmanus self-assigned this Dec 9, 2017
@sean-mcmanus sean-mcmanus added this to the January 2018 milestone Dec 9, 2017
@sean-mcmanus
Copy link
Contributor

I'm not able to repro this with the 0.14.5. You may need to clear out the "macFrameworkPath" setting.

@sean-mcmanus sean-mcmanus removed their assignment Dec 20, 2017
@sean-mcmanus sean-mcmanus added more info needed The issue report is not actionable in its current state and removed bug labels Dec 20, 2017
@sean-mcmanus sean-mcmanus removed this from the January 2018 milestone Dec 20, 2017
@sean-mcmanus sean-mcmanus added this to the August 2018 milestone Aug 2, 2018
@sean-mcmanus sean-mcmanus added Feature Request fixed Check the Milestone for the release in which the fix is or will be available. and removed more info needed The issue report is not actionable in its current state labels Aug 2, 2018
@sean-mcmanus
Copy link
Contributor

Fixed with 0.18.0.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature Request fixed Check the Milestone for the release in which the fix is or will be available. Language Service
Projects
None yet
Development

No branches or pull requests

3 participants