Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Fix typo: sourceMapOverrides -> sourceMapPathOverrides. #194

Merged
merged 1 commit into from
Jul 10, 2016

Conversation

lijunle
Copy link
Member

@lijunle lijunle commented Jul 9, 2016

Fix typo: sourceMapOverrides -> sourceMapPathOverrides.

Fix typo: sourceMapOverrides -> sourceMapPathOverrides.
@msftclas
Copy link

msftclas commented Jul 9, 2016

Hi @lijunle, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Junle Li). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@nojvek
Copy link
Contributor

nojvek commented Jul 9, 2016

This is purely a documentation change right?

LGTM.

@lijunle
Copy link
Member Author

lijunle commented Jul 9, 2016

Yes. I copied the code snippet to VS code. It draw a green underline on it. In the paragraph above the code snippet, the option has a different name.

@nojvek
Copy link
Contributor

nojvek commented Jul 9, 2016

It seems the doco has some some unicode emoticons. Might want to fix that.

"sourceMapOverrides": {
    "webpack:///*": "${webRoot}/*", // Example: "webpack:///src/app.js" -> "/users/me/project/src/app.js"
    "meteor://💻app/*": "${webRoot}/*" // Example: "meteor://💻app/main.ts" -> "c:/code/main.ts"
}

@lijunle
Copy link
Member Author

lijunle commented Jul 10, 2016

It was originally there, I don't touch it.

@lijunle
Copy link
Member Author

lijunle commented Jul 10, 2016

@roblourens the doc has some Unicode chars in the code snippet. Is that expected?

@roblourens roblourens merged commit 894d48d into microsoft:master Jul 10, 2016
@roblourens
Copy link
Member

Thanks!

@lijunle lijunle deleted the patch-1 branch July 10, 2016 19:56
@lijunle
Copy link
Member Author

lijunle commented Jul 10, 2016

@roblourens How about the Unicode emoji - 💻? Are we going to keep them?

@roblourens
Copy link
Member

Yeah it's supposed to be there.

@lijunle
Copy link
Member Author

lijunle commented Jul 10, 2016

Aha! It looks crazy to have emoji in a path. 😃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants