Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Enable source maps by default to simplify configuration #134

Closed
auchenberg opened this issue Nov 29, 2016 · 6 comments
Closed

Enable source maps by default to simplify configuration #134

auchenberg opened this issue Nov 29, 2016 · 6 comments
Assignees
Milestone

Comments

@auchenberg
Copy link
Contributor

Given the popularity of sourcemaps we should flip our default setting, so sourcemap support are enabled by default.

Rational:
If a source map is present it's most likely needed to resolve paths correctly. Some people don't notice the sourcemap config, and end up with a bad first time experience.

We should therefore flip the setting, and explicitly allow people to disable source maps if needed.

This would simplify the default configs too.

@roblourens
Copy link
Member

Thoughts on this @weinand? It shouldn't break anyone since you can turn on 'sourceMaps' then debug your code without sourcemaps just fine.

@weinand
Copy link

weinand commented Dec 5, 2016

If this change affects node2, then we will have to flip the defaults in node1 as well.
I will investigate what consequences this has in the January milestone.

@roblourens
Copy link
Member

Right, it should be consistent across. We can change it in chrome-debug to experiment.

@auchenberg
Copy link
Contributor Author

Let's ship this in the Chrome debugger, and evaluate the results.

roblourens added a commit to microsoft/vscode-chrome-debug that referenced this issue Jan 2, 2017
@roblourens
Copy link
Member

Enabled for chrome-debug in 2.4.2!

@auchenberg
Copy link
Contributor Author

Yay. Let's see how people are gonna react to this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants