Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HostNameInCertificate Fix #644

Merged
merged 7 commits into from
May 29, 2018
Merged

HostNameInCertificate Fix #644

merged 7 commits into from
May 29, 2018

Conversation

peterbae
Copy link
Contributor

@peterbae peterbae commented Mar 5, 2018

Fixes issue #623

@codecov-io
Copy link

codecov-io commented Mar 5, 2018

Codecov Report

Merging #644 into dev will decrease coverage by 0.04%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #644      +/-   ##
============================================
- Coverage     48.17%   48.13%   -0.05%     
+ Complexity     2585     2584       -1     
============================================
  Files           114      114              
  Lines         26578    26586       +8     
  Branches       4453     4455       +2     
============================================
- Hits          12805    12796       -9     
- Misses        11634    11647      +13     
- Partials       2139     2143       +4
Flag Coverage Δ Complexity Δ
#JDBC42 48.01% <37.5%> (+0.03%) 2576 <0> (+1) ⬆️
#JDBC43 48.02% <37.5%> (-0.02%) 2580 <0> (+1)
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.67% <37.5%> (-0.03%) 288 <0> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.11% <0%> (-0.3%) 0% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39.18% <0%> (-0.22%) 43% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.21% <0%> (-0.2%) 245% <0%> (-2%)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 77.85% <0%> (-0.17%) 4% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.26% <0%> (-0.07%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.67% <0%> (ø) 241% <0%> (+2%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.41% <0%> (+0.44%) 107% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f4f1d...4b128db. Read the comment docs.

@rene-ye rene-ye self-requested a review March 6, 2018 18:24
rene-ye
rene-ye previously approved these changes Mar 6, 2018
@peterbae
Copy link
Contributor Author

peterbae commented Apr 4, 2018

Closing this as this fix was unnecessary, the issue was apparently coming from Azure's end.

@peterbae peterbae closed this Apr 4, 2018
@peterbae peterbae reopened this May 14, 2018
@rene-ye rene-ye added this to the 6.5.3 milestone May 29, 2018
@peterbae peterbae merged commit eb312a0 into microsoft:dev May 29, 2018
@peterbae peterbae deleted the github-623 branch May 29, 2018 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants