-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AAD integration auth using DLL and ADAL4J #603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D-integrated-investigation
Codecov Report
@@ Coverage Diff @@
## dev #603 +/- ##
============================================
+ Coverage 46.44% 46.52% +0.07%
+ Complexity 2219 2215 -4
============================================
Files 108 108
Lines 25340 25363 +23
Branches 4178 4179 +1
============================================
+ Hits 11770 11799 +29
+ Misses 11546 11538 -8
- Partials 2024 2026 +2
Continue to review full report at Codecov.
|
cheenamalhotra
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If operating system is Windows, use DLL to authenticate with integrated authentication mode, otherwise use ADAL4j dependency.
If DLL is not loaded or operating system is not windows use ADAL4J.
Note: This PR fails for now because it requires ADAL4J 1.4.0 release