fix: remove hypertext styles from button #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasrice
approved these changes
Jun 16, 2020
scomea
approved these changes
Jun 16, 2020
| @@ -37,7 +36,6 @@ import { | |||
| export const ButtonStyles = css` | |||
| ${BaseButtonStyles} | |||
| ${AccentButtonStyles} | |||
| ${HypertextStyles} | |||
There was a problem hiding this comment.
should this change be made in fast-components as well?
janechu
approved these changes
Jun 16, 2020
chrisdholt
force-pushed
the
users/chhol/remove-hypertext-styles-from-button
branch
from
257908b to
ffe0c8a
Compare
janechu
approved these changes
Jun 17, 2020
EisenbergEffect
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fast-buttonwas including the hypertext styles as part of its stylesheet, but there is no "hypertext" appearance onfast-button.Motivation & context
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist