Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure all component internals have part names #3306

Merged
merged 3 commits into from
Jun 15, 2020
Merged

fix: ensure all component internals have part names #3306

merged 3 commits into from
Jun 15, 2020

Conversation

chrisdholt
Copy link
Member

Description

There were a few components with missing part names. This PR adds them.

Motivation & context

Issue type checklist

  • Chore: A change that does not impact distributed packages.
  • Bug fix: A change that fixes an issue, link to the issue above.
  • New feature: A change that adds functionality.

Is this a breaking change?

  • This change causes current functionality to break.

Adding or modifying component(s) in @microsoft/fast-components checklist

Process & policy checklist

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@chrisdholt chrisdholt self-assigned this Jun 15, 2020
@chrisdholt chrisdholt merged commit 95360a7 into master Jun 15, 2020
@chrisdholt chrisdholt deleted the users/chhol/ensure-all-components-have-part-names branch June 15, 2020 20:26
@EisenbergEffect EisenbergEffect mentioned this pull request Jun 16, 2020
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janechu janechu janechu approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

@nicholasrice nicholasrice Awaiting requested review from nicholasrice

Assignees

@chrisdholt chrisdholt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdholt @EisenbergEffect @janechu