feat: adds accordion config to component explorer #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljefe223
requested review from
awentzel,
EisenbergEffect and
Falkicon
as code owners
eljefe223
changed the title
eljefe223
force-pushed
the
users/jes/config-wc-work
branch
from
cb17acb to
8685fee
Compare
EisenbergEffect
approved these changes
Jun 11, 2020
| required: false, | ||
| }, | ||
| ], | ||
| slots: [ |
There was a problem hiding this comment.
Does accordion not have a default slot?
There was a problem hiding this comment.
Nope only a slot for item
There was a problem hiding this comment.
Do the accordion items automatically set their slot to item by any chance?
nicholasrice
approved these changes
Jun 11, 2020
eljefe223
force-pushed
the
users/jes/config-wc-work
branch
from
8685fee to
befe330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
fast-accordionconfig a more complex config file for the component explorerIssue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist