Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(axe-4.7): update to use axe-core 4.7.2 #1061

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

madalynrose
Copy link
Contributor

@madalynrose madalynrose commented Aug 3, 2023

Details

This PR upgrades axe-core to 4.7.2 according to the instructions in CONTRIBUTING.md.

Additionally, it adds a script that uses @puppeteer/browsers to install a specific version of Chrome and move it to the default windows install location, which is expected by ChromeDriver.

It also adds @axe-core/cli to dependabot,yml since we want to include it in axe-core upgrades and not before.

Motivation

feature work 🚀

Context

Pull request checklist

  • PR title respects Conventional Commits (starts with fix:, feat:, etc, and is suitable for user-facing release notes)
  • PR contains no breaking changes, OR description of both PR and final merge commit starts with BREAKING CHANGE:
  • [n/a] (if applicable) Addresses issue: #0000
  • [n/a] Added relevant unit tests for your changes
  • Ran yarn precheckin
  • Verified code coverage for the changes made

@madalynrose madalynrose requested a review from a team as a code owner August 3, 2023 19:27
Copy link
Contributor

@DaveTryon DaveTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script to create new test resources worked for me :)

@madalynrose madalynrose changed the title feat(axe-4.7): Upgrade axe core to 4.7.2 feat(axe-4.7): update to use axe-core 4.7.2 Aug 4, 2023
@madalynrose madalynrose merged commit ab8306b into microsoft:main Aug 4, 2023
@madalynrose madalynrose deleted the axe-core-4.7.2 branch August 4, 2023 17:43
@ada-cat
Copy link
Collaborator

ada-cat commented Aug 4, 2023

🎉 This PR is included in version 2.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants