Address 'Code Clone Detection' results

[mrlacey]

The 'Code Clone Detection' functionality in VSEnt highlights some areas where we can improve the generator code base.

I see 705 lines of Cloned Code.

Some of the duplication in test code might not be worth removing but there's strong evidence of someone having abused cut-and-paste when it comes to other code.

[crutkas]

Think this may be a good idea to do.

[sibille]

ok!

[sibille]

eliminated the exact matches, moving to 2.4 for the rest

[crutkas]

is this a tracked item for this release?

[sibille]

I'd prefer to do this on 3.0 branch

[crutkas]

lower priority due to wizard code, lets do in 3.0

Are we doing the test on generated projects as well?

[mrlacey]

Are we doing the test on generated projects as well?

As we aim to only have minimal, necessary, code in the generated projects and the generated code should be easy to understand, I would not expect any clones to be found. If any were found, removing the duplication would likely make the generated code harder to read/understand.

[crutkas]

lets just do a sanity check for generated projects but i do agree we chances are this would be a low chance we would dup code per your statement @mrlacey

[dgomezc]

We have refactored the duplicated code in the UI and Core projects, and some cases that we thought convenient in the tests. We have ignored the rest of the duplicated code in the tests (adding .codeclonesettings files) since they are initializations and we think it is more understandable that way.

In the generated projects, there is only duplicated code when adding Ink Pages, since the initializations of the services are very similar, and in a configuration method of the CameraControl, which contains 2 similar switch statements. We think that the code is easier to understand as it is, so we think there is no action to take here.

[sibille]

verified in dev