Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add refactoring option to convert string concatenation to template literals #18267

Closed
alex-kinokon opened this issue Sep 6, 2017 · 7 comments · Fixed by #30565
Closed

Add refactoring option to convert string concatenation to template literals #18267

alex-kinokon opened this issue Sep 6, 2017 · 7 comments · Fixed by #30565
Labels
Committed The team has roadmapped this issue Domain: Refactorings e.g. extract to constant or function, rename symbol Fixed A PR has been merged for this issue Suggestion An idea for TypeScript Update Docs on Next Release Indicates that this PR affects docs
Milestone
TypeScript 3.8.0

Comments

@alex-kinokon
Copy link

Consider adding the refactoring option to turn a string concatenation

console.log("My name is " + firstName + " " + lastName + ".");

to ES2015 template literals:

console.log(`My name is ${firstName} ${lastName}.`);
@DanielRosenwasser DanielRosenwasser added Domain: Refactorings e.g. extract to constant or function, rename symbol Suggestion An idea for TypeScript labels Sep 6, 2017
@alex-kinokon
Copy link
Author

Would you welcome a pull request for this?

@mhegazy
Copy link
Contributor

mhegazy commented May 7, 2018

Yes.

@alex-kinokon
Copy link
Author

I definitely need some help on this one...

@mhegazy
Copy link
Contributor

mhegazy commented Jun 6, 2018

I would look at https://github.com/Microsoft/TypeScript/blob/master/src/services/refactors/generateGetAccessorAndSetAccessor.ts for a reference

@mhegazy mhegazy mentioned this issue Jun 12, 2018
Closed
4 tasks
@weswigham weswigham added the In Discussion Not yet reached consensus label Nov 6, 2018
@bigaru
Copy link
Contributor

bigaru commented Nov 28, 2018

@glixlur is it okay for you?
If I would provide a PR for this issue

@alex-kinokon
Copy link
Author

@bigaru Yes!

bigaru added a commit to D0nGiovanni/TypeScript that referenced this issue Dec 5, 2018
@bigaru
complete interface stubbing for object literal
019a160 
 interface stubbing microsoft#18267
@bigaru bigaru mentioned this issue Dec 9, 2018
Closed
@bigaru bigaru mentioned this issue Mar 24, 2019
Merged
@mjbvz mjbvz mentioned this issue Jun 6, 2019
Closed
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.8.0 milestone Nov 1, 2019
@DanielRosenwasser DanielRosenwasser mentioned this issue Nov 4, 2019
Closed
@RyanCavanaugh RyanCavanaugh removed their assignment Nov 4, 2019
@RyanCavanaugh RyanCavanaugh added Committed The team has roadmapped this issue and removed In Discussion Not yet reached consensus labels Nov 4, 2019
@Klaster1 Klaster1 mentioned this issue Nov 12, 2019
Open
@mjbvz mjbvz mentioned this issue Nov 15, 2019
Closed
@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Jan 3, 2020
@DanielRosenwasser
Copy link
Member

Thanks @bigaru!

@DanielRosenwasser DanielRosenwasser added the Update Docs on Next Release Indicates that this PR affects docs label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Committed The team has roadmapped this issue Domain: Refactorings e.g. extract to constant or function, rename symbol Fixed A PR has been merged for this issue Suggestion An idea for TypeScript Update Docs on Next Release Indicates that this PR affects docs
Projects
None yet
Milestone
TypeScript 3.8.0
Development

Successfully merging a pull request may close this issue.

add refactoring: string concatenation to template literals D0nGiovanni/TypeScript
6 participants
@DanielRosenwasser @weswigham @RyanCavanaugh @mhegazy @alex-kinokon @bigaru