Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error or warning message if @Directive SDL string contains newline characters #1423

Closed
carlocorradini opened this issue Feb 15, 2023 · 0 comments · Fixed by #1669
Closed

Add error or warning message if @Directive SDL string contains newline characters #1423

carlocorradini opened this issue Feb 15, 2023 · 0 comments · Fixed by #1669
Assignees
@carlocorradini
Labels
Bug 🐛 Something isn't working Community 👨‍👧 Something initiated by a community Solved ✔️ The issue has been solved
Milestone
2.0 release

Comments

@carlocorradini
Copy link
Contributor

Add an error or warning message if @directive SDL string contains newline characters.
If SDL contains a newline character the directive is completely and silently ignored.
@MichalLytek MichalLytek added Bug 🐛 Something isn't working Community 👨‍👧 Something initiated by a community labels Feb 15, 2023
@MichalLytek MichalLytek added this to the 2.0 release milestone Feb 15, 2023
@carlocorradini carlocorradini mentioned this issue Apr 20, 2024
Merged
@MichalLytek MichalLytek added the Solved ✔️ The issue has been solved label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlocorradini carlocorradini

Labels
Bug 🐛 Something isn't working Community 👨‍👧 Something initiated by a community Solved ✔️ The issue has been solved
Projects
None yet
Milestone
2.0 release
Development

Successfully merging a pull request may close this issue.

fix(directives): allow multiline and leading spaces carlocorradini/type-graphql
3 participants
@MichalLytek @carlocorradini and others