DietPi-WiFiDB | Enhancements #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ DietPi-WiFiDB | Switch to store WiFiDB with single quotes to reduce escape effort + DietPi-WiFiDB | Do required escaping script internally, to save user from doing this and us to maintain documentation about it + DietPi-WiFiDB | Only ask for WiFi key, if SSID and key manager was successfully chosen, otherwise reset values of the slot and return to slot overview + DietPi-WiFiDB | Set ERROR_CODE=0 as default, as currently it always exits with ERROR_CODE=1, if valid INPUT was set. + DietPi-WiFiDB | Minor wording and coding
|
Note: |
Fourdee
reviewed
Oct 30, 2018
+ DietPi-WiFiDB | Non-capital, renamed and pre-declared return code: https://github.com/Fourdee/DietPi/pull/2193#discussion_r229350445
|
Great work, looks good 👍 Lets merge for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Testing
🈯️ Native x86_64 Stretch
Reference: https://github.com/Fourdee/DietPi/pull/2177#issuecomment-433071910
Commit list/description:
dietpi-wifi.dbrequires "escaping" of single quote only, which is only possible via'\''to close single quoted literal string, insert escaped single quote and reopen literal single quoted string till the end. Insidewpa_supplicant.conf, double quotes for SSID, key, user and password are required, but no escaping, not even of double quote, required, since the values are parsed from first till last double quote 😃, intelligent solution. Single and double quotes and backslashes within bash variable manipulation${VAR//<old>/<new}need to be escaped by backslash. This is then how the code came out, e.g.:'${aWIFI_SSID[$i]//\'/\'\\\'\'}'EAPsettings, in case chosen as key manager.1, only0if invalid input was given. I guess this should have been the other way round 😆. But at least should not break anything, since this error code is never used so far.