Regularly trigger ADD_CALENDAR to ensure calendar fetcher is running #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated |
|
It might be a cleaner idea to broadcast a message to all modules whenever the socket connection is (re-) established. In that case you can broadcast ADD_CALENDAR whenever this happens. For now your solution seems fine and we can always change the impementation... Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently an
ADD_CALENDARnotification is only sent once when the calendar module is started in the UI. This notification creates a calendar fetcher on the server side that is used to regularly update the calendar.When MagicMirror is running in
serveronlymode, the server process can be restarted even while the UI keeps running. When the server process restarts, it launches with no calendar fetchers running, and there is currently no way to start them again other than to refresh the UI.This change just fires an
ADD_CALENDARevent every fetch interval. When such event is received by the server that already has a fetcher running, it's effectively ignored (i.e. no duplicate fetcher is started), however if there is no fetcher running (because the server has been restarted) this makes sure it gets started.