Change weatherforecast and currentweather unit display

[fwitte]

Hi everybody,
I just started building/configuring my own MM and found a bug using "default" for the units. The degree symbol should not be displayed. It is degree Celsius and degree Fahrenheit, but not degree Kelvin.

weatherforecast
https://github.com/MichMich/MagicMirror/blob/de57daa3cd881ce1a14b88307bf61e8109879c81/modules/default/weatherforecast/weatherforecast.js#L145-L158

currentweather
https://github.com/MichMich/MagicMirror/blob/de57daa3cd881ce1a14b88307bf61e8109879c81/modules/default/currentweather/currentweather.js#L200-L213

https://github.com/MichMich/MagicMirror/blob/de57daa3cd881ce1a14b88307bf61e8109879c81/modules/default/currentweather/currentweather.js#L221

I suggest changing the display for both modules like this:

var degreeLabel = "";
if(this.config.scale) {
	switch(this.config.units) {
	case "metric":
		degreeLabel += "° C";
		break;
	case "imperial":
		degreeLabel += "° F";
		break;
	case "default":
		degreeLabel = " K";
		break;
	}
}

currentweather

temperature.innerHTML = " " + this.temperature.replace(".", this.config.decimalSymbol) + degreeLabel;

weatherforecast

maxTempCell.innerHTML = forecast.maxTemp.replace(".", this.config.decimalSymbol) + degreeLabel;
minTempCell.innerHTML = forecast.minTemp.replace(".", this.config.decimalSymbol) + degreeLabel;

If these changes are okay with you, I will open two PR for this issue.

[MichMich]

A PR is more than welcome! Thanks!

[MichMich]

Merged.

[fewieden]

I will also change it for the new weather module.

Done will be in the next pr

[fewieden]

Handled in #1510 for the new weather module.