Useless switch

[RudeySH]

I found this switch in the source code:

switch (country_code) {     
  case "AT":
    if (country_code == "AT") {
      valid_country = true;
    }
   break;        
  case "BE":
    if (country_code == "BE") {
      valid_country = true;
    }
    break;
    
    // ... etc. ...
    
  default:
    valid_country = false;
    break;
}

This seems fairly useless.

[nolialsea]

It IS useless, and even worse, on line 197-199, the country_code can NEVER be "GF"/"PF"/"TF"

[RudeySH]

What the hell.

Anyway, this should be replaced with something simple like this:

var known_codes = ["AT", "BE", ...];
valid_country = (known_codes.indexOf(country_code) !== -1);

[jbilcke]

it looks like the skeleton of an older, more living switch:
c362076

I don't remember exactly why I left it in the closet, but that definitely should have been cleaned up

however this fork has not been updated for 3 years, so I think it would be better to use the original http://www.braemoor.co.uk/software/vat.shtml which has been updated since that time