-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dealing with GodSVG's blurriness #342
Comments
I have a 1440p monitor at a higher PPI than your typical 21"-27" 1080p display. This means that things typically look smaller on my monitor if they were made for 1080p displays. In my opinion, even with the probably-smaller-than-intended UI elements, the UI elements in the default window size are perfectly fine! I would recommend disabling scaling by default and having UI scaling options in the preferences. This would allow for better rendering code to be written in the future for cleaner large-scale UI (e.g., a 24x24 button at 2x scale is actually rendered at 48x48, rather than the window texture being scaled up with texture filtering). I propose three scaling options:
Additionally, they should be able to choose whether UI is scaled per nearest-neighbour ("Pixel-perfect"?) and bilinear ("Smoothed"?). In the future, the texture-based scaling could be removed completely, and (as suggested before,) be replaced with code that actually renders things with the appropriate scale at full resolution. However, as GodSVG is still in alpha, I doubt this is a major focus at the moment. |
Yeah, that's the exact plan. I plan to work on theme generation soon, so that'll unlock one of the points for implementing factor scale. But I can't have a small texture get upscaled, that'd be blurry, no? Godot editor has scaling settings and even there the implementation is to just litter all of the code with EDSCALE arguments, it has to be considered for everything. |
Maybe make those textures with SVGs and then re-render them according to the size at which they'll be seen? |
Last time I tried, I didn't find any way to apply this throughout the whole application. |
Pretty much solved by #661 |
The current situation with GodSVG's scaling is very unhappy.
Disabled scaling:
Canvas items scaling mode (current):
The current idea is to move to disabled scaling mode, but I've decided that its downside is worse than that of canvas item scaling. So not until a setting for editor scale is added.
I imagine such a setting could go from something like
1x
to2x
. I am not sure how it would be implemented: I imagine with lots of bubblegum and shoestrings. But the main things are:I feel like some things may be doable, to some extent, in more sweeping ways than via script, but I don't know which ones, how, and if there would be any complications in using those ways.
The text was updated successfully, but these errors were encountered: