Issues with two project cards: missing link IDs & “frontage” does not conform with data schema

[yueshuaing]

During the processes of converting and applying project cards using the new Network Wrangler, we noticed issues with two project cards:

1. Project card hia_46th_cleanup.yml
   This project card deletes four links that are not in the base standard network. It might be necessary to review the network again to identify the exact link IDs.

2. Project card Th65sb.yml
   This project card adds several new roadways, with roadway set to frontage. The new project card JSON schema does not define roadway: frontage in its roadway category. Elizabeth commented that the roadway category is consistent with OSM terminology, suggesting that this should likely be coded as secondary and then given a tag from frontage_road = True. See https://www.openstreetmap.org/way/131281643#map=17/30.286142/-97.722879
   Can we modify it to secondary without adding a new variable frontage_road? Will this affect any model results?

[RachelWikenMC]

Hi - I was on vacation last week, getting through all my emails.

1. I can look at that area again. That cleanup card was part of the transit review when I found weird links connected the LRT station to the far side of Hiawatha expressway which did not exist in real life.
2. changing roadway to secondary is fine. we are not tracking frontage. Dennis built that card and probably didn't realize roadway had set variables

[RachelWikenMC]

I want to confirm changes to project cards will be a new set of cards and leave the originals in my current branch of the repo. I need to double check some network project cards this week for our policy plan.

[yueshuaing]

Thanks for confirming. Yes, we will leave the old project cards in the original branch. And we will check in the new project cards to a new branch.

[yueshuaing]

Hi - I was on vacation last week, getting through all my emails.

1. I can look at that area again. That cleanup card was part of the transit review when I found weird links connected the LRT station to the far side of Hiawatha expressway which did not exist in real life.
2. changing roadway to secondary is fine. we are not tracking frontage. Dennis built that card and probably didn't realize roadway had set variables

Update on item1:
Pending

Update on item2:
The roadway: frontage is now set to secondary in the converted Th65sb.yml

[RachelWikenMC]

Thanks for reminder, item #1 was forgotten. will check

[yueshuaing]

Confirming item1 has been fixed in https://github.com/Metropolitan-Council/met_council_wrangler/commit/ef8cbff1e96e01063e208f02e217820d13c15458. I'll close this issue.