Committees: Committees with no current members are listed

[shrayshray]

On the Committees page (https://boardagendas.metro.net/committees/) two committees which are no longer active are still showing up on the list, several days after being updated.
Ac Hoc Sustainability has no active members listed in Legistar, but it's showing up twice.
System Safety, Security and Operations also has no active members, but is still listed (and shows 7 members).

[reginafcompton]

@shrayshray - can you confirm that Metro added and later deleted members to the System Safety, Security and Operations Committee? If so, then this issue relates to opencivicdata/pupa#295, and DataMade will need to carefully delete the extraneous memberships from our data source (see below screenshot).

Excerpt of OCD API: It contains memberships for System Safety Committee dating through 2019

https://ocd.datamade.us/ocd-organization/89c32d8d-5bc1-4cd8-9316-3f0031984ba5/

These members do not appear in the Legistar source data.

[reginafcompton]

For the Ad-Hoc Sustainability Committee, we have Phil Washington's membership ending in 2020 (see below screenshot). Let's determine how that happened.

https://ocd.datamade.us/ocd-organization/f40445d3-7036-49df-992c-4ba218b8d6b4/

Phil Washington has the correct end date in Legistar source:
http://webapi.legistar.com/v1/metro/bodies/176/officerecords

[shrayshray]

@reginafcompton Phil Washington's membership was originally set to end in 2020, but because the meeting is on hiatus, I changed it to end 6/30/18. I made the change 7/3/18.

[shrayshray]

@reginafcompton re: "can you confirm that Metro added and later deleted members to the System Safety, Security and Operations Committee?"
Yes. I added new members before finding out the committee name was going to be changed, then deleted them and added them to the new committee.

[reginafcompton]

Steps used to remove the inaccurate memberships from Safety, Security and Operations Committee:

• Turn off cron

• Delete memberships from OCD API database: Execute the following in an api.opencivicdata.org shell

from opencivicdata.core.models import Membership

people = ['ocd-person/7458da90-f5da-465f-8246-00ef9b2a3527', 'ocd-person/c1be7315-f376-4092-b6ca-b1533a264870', 'ocd-person/dbc51fa2-6e20-4a00-b099-851703b7b19d', 'ocd-person/31afabe2-7e96-4394-9a32-f9f830cb255d', 'ocd-person/6b9fb5e9-b1ea-4615-b538-3d501fbcf51c', 'ocd-person/912c8ddf-8d04-4f7f-847d-2daf84e096e2', 'ocd-person/75cce355-15b7-46fd-880e-af5a8ab39aad']

memberships = Membership.objects.filter(person_id__in=people, organization_id='ocd-organization/89c32d8d-5bc1-4cd8-9316-3f0031984ba5',end_date__in=['2019-06-30', '2020-06-30'])

[membership.delete() for membership in memberships]

• Delete the memberships from Councilmatic downloads on the server

rm -rf downloads/people/*

• Delete the memberships from Councilmatic database: Execute the following in an la-metro-councilmatic shell

from councilmatic_core.models import Membership

people = ['ocd-person/7458da90-f5da-465f-8246-00ef9b2a3527', 'ocd-person/c1be7315-f376-4092-b6ca-b1533a264870', 'ocd-person/dbc51fa2-6e20-4a00-b099-851703b7b19d', 'ocd-person/31afabe2-7e96-4394-9a32-f9f830cb255d', 'ocd-person/6b9fb5e9-b1ea-4615-b538-3d501fbcf51c', 'ocd-person/912c8ddf-8d04-4f7f-847d-2daf84e096e2', 'ocd-person/75cce355-15b7-46fd-880e-af5a8ab39aad']

memberships = Membership.objects.filter(_person_id__in=people, _organization_id='ocd-organization/89c32d8d-5bc1-4cd8-9316-3f0031984ba5',end_date__in=['2019-06-30', '2020-06-30'])

[membership.delete() for membership in memberships]

• Delete inaccurate meeting (ocd-event/0a711607-0058-4ebe-808c-fe5338e5a9f4 and ocd-event/3ca385c8-24b0-4c83-92ca-68a783697fc2) using this guide. Handles part of Meetings: New System Safety Committee to replace "System Safety, Security and Operations" #315

• Delete lingering EventParticipants in Councilmatic (for the System Safety, Security and Operations Committee):

delete from councilmatic_core_eventparticipant where entity_name='System Safety, Security and Operations Committee' and event_id in ('ocd-event/b86561a8-5647-41b5-9ebc-d78fed3b95b5','ocd-event/ab9220ab-66ea-4c8b-b7e7-f5e4590e08ce','ocd-event/c0ceb9f6-d677-4b04-ba26-042318cddc76');

• Turn on cron

[reginafcompton]

@shrayshray - this issue should be handled with the exception of Phil Washington's membership. I opened a separate issue for that: #318 I'll take a look at it first thing tomorrow morning.

Closing this issue!