Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL errors are discarded #4

Closed
ghost opened this issue Apr 19, 2016 · 1 comment
Closed

SQL errors are discarded #4

ghost opened this issue Apr 19, 2016 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 19, 2016

The current promise implementation discards the error object, which actually has information about the error, while the transaction object does not.

below my proposed change:

DB.prototype.executeSql = function(query, args) {
  var that = this;
  return new Promise(function(resolve, reject) {
    that.db.transaction(function(t) {
      t.executeSql(query, args,
        function(t, r) {
          resolve(r);
        },
      //  function(e) {
       function(tx,err)
          console.log(err);
          reject(err);
        });
    });
  });
};

Thanks!

@MetaMemoryT
Copy link
Owner

Sure that sounds reasonable, send a pull request and I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant