Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packageJsonStruct to allow repository.directory #2754

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

alber70g
Copy link
Contributor

When releasing a package from a monorepo the repository.directory is used to identify which package is been released. This is used for the Github build provenance.

When releasing a package from a monorepo the `repository.directory` is used to identify which package is been released. This is used for the Github build provenance.
@alber70g alber70g requested a review from a team as a code owner September 24, 2024 14:29
@Mrtenz
Copy link
Member

Mrtenz commented Sep 24, 2024

Hi @alber70g, thanks for your PR! It looks like there's a lint issue:

Run yarn workspace @metamask/snaps-utils run lint:ci

/home/runner/work/snaps/snaps/packages/snaps-utils/src/types.ts
Error: 4:3 error 'object' is defined but never used @typescript-eslint/no-unused-vars

Happy to get this merged once you fixed that.

@alber70g
Copy link
Contributor Author

When this is merged, how long will it take to be released on npm?

@Mrtenz Mrtenz merged commit 7d15013 into MetaMask:main Sep 26, 2024
163 checks passed
@Mrtenz
Copy link
Member

Mrtenz commented Sep 26, 2024

When this is merged, how long will it take to be released on npm?

We're planning to do a release this week!

@barthuijgen
Copy link

Hi, I see this was released on 26 Sept, and we were able to update the build tooling to build our snap. But the Flask extension does not accept it yet. I've updated it to version 12.3.0-flask.0 but it gives a error installing our snap that repository.directory should be never.

Could you please look into publishing a new version of the extension with this change included? Thank you.

@Mrtenz
Copy link
Member

Mrtenz commented Oct 1, 2024

Hi, I see this was released on 26 Sept, and we were able to update the build tooling to build our snap. But the Flask extension does not accept it yet. I've updated it to version 12.3.0-flask.0 but it gives a error installing our snap that repository.directory should be never.

Could you please look into publishing a new version of the extension with this change included? Thank you.

The updated version of snaps-utils is included in this PR: MetaMask/metamask-extension#27376. Unfortunately the extension is bound to a tight release schedule so it can take some weeks before this is included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants