From 6f9ca36c203e1b1b1ca50c6e4fbebb8fa3bb54cb Mon Sep 17 00:00:00 2001
From: Frederik Bolding <frederik.bolding@gmail.com>
Date: Tue, 9 Apr 2024 10:39:08 +0200
Subject: [PATCH] Disable GitHub flavored Markdown when lexing (#2317)

`marked` has GitHub flavored Markdown enabled by default, but we don't
support GitHub flavored Markdown in the UI. This makes the validation
stricter than it needs to be. This PR fixes that by disabling GitHub
flavored Markdown when lexing.
---
 packages/snaps-utils/src/ui.test.ts | 15 ++++++++-------
 packages/snaps-utils/src/ui.ts      |  2 +-
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/packages/snaps-utils/src/ui.test.ts b/packages/snaps-utils/src/ui.test.ts
index 140e892bde..ed2cb6cec7 100644
--- a/packages/snaps-utils/src/ui.test.ts
+++ b/packages/snaps-utils/src/ui.test.ts
@@ -58,6 +58,12 @@ describe('validateTextLinks', () => {
     ).not.toThrow();
   });
 
+  it('passes for non-links', () => {
+    expect(() =>
+      validateTextLinks('Hello **http://localhost:3000**', () => false),
+    ).not.toThrow();
+  });
+
   it('throws an error if an invalid link is found in text', () => {
     expect(() =>
       validateTextLinks('[test](http://foo.bar)', () => false),
@@ -76,17 +82,12 @@ describe('validateTextLinks', () => {
     ).toThrow('Invalid URL: Protocol must be one of: https:, mailto:.');
 
     expect(() =>
-      validateTextLinks(
-        `[foo][1]
-         [1]: http://foo.bar`,
-        () => false,
-      ),
+      validateTextLinks('[foo][1]\n\n[1]: http://foo.bar', () => false),
     ).toThrow('Invalid URL: Protocol must be one of: https:, mailto:.');
 
     expect(() =>
       validateTextLinks(
-        `[foo][1]
-         [1]: http://foo.bar "foo bar baz"`,
+        `[foo][1]\n\n[1]: http://foo.bar "foo bar baz"`,
         () => false,
       ),
     ).toThrow('Invalid URL: Protocol must be one of: https:, mailto:.');
diff --git a/packages/snaps-utils/src/ui.ts b/packages/snaps-utils/src/ui.ts
index ca76576ea7..29f80913e6 100644
--- a/packages/snaps-utils/src/ui.ts
+++ b/packages/snaps-utils/src/ui.ts
@@ -13,7 +13,7 @@ const ALLOWED_PROTOCOLS = ['https:', 'mailto:'];
  * @returns A list of URLs linked to in the string.
  */
 function getMarkdownLinks(text: string) {
-  const tokens = lexer(text);
+  const tokens = lexer(text, { gfm: false });
   const links: (Tokens.Link | Tokens.Generic)[] = [];
 
   // Walk the lexed tokens and collect all link tokens