Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run benchmarks from node core on CI #8

Open
whymarrh opened this issue Feb 18, 2020 · 3 comments
Open

Run benchmarks from node core on CI #8

whymarrh opened this issue Feb 18, 2020 · 3 comments

Comments

@whymarrh
Copy link
Contributor

Node.js has a set of benchmarks used to measure the performance of the EventEmitter implementation—we should run those against our implementation on CI.
@whymarrh
Copy link
Contributor Author

An example benchmark:

"binary", "filename", "configuration", "rate", "time"
"old", "events/ee-emit.js", "listeners=1 argc=0 n=2000000", 60918630.40663886, 0.032830679

@whymarrh
Copy link
Contributor Author

whymarrh commented Sep 2, 2020

The desire for this arose with the migration to TypeScript (#1) and the suspicion that some non-functional changes may introduce performance regressions. This doesn't need to be blocking.

@whymarrh whymarrh mentioned this issue Sep 2, 2020
Closed
6 tasks
@Eyesdown

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whymarrh @Eyesdown