chore: Migrate to Yarn 4, use JS constraints #156
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
rekmarks
force-pushed
the
rekm/yarn-4
branch
from
709936e
to
604bd67
Compare
|
|
||
| const pullRequestTemplate = await getWorkspaceFile( | ||
| workspace, | ||
| '.github/pull_request_template.md', |
There was a problem hiding this comment.
The file name here is allcaps in the module template, and this blows up in Node 22.
| @@ -7,29 +7,47 @@ jobs: | |||
| prepare: | |||
| name: Prepare | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node-version: [18.x, 20.x, 22.x] | |||
There was a problem hiding this comment.
Node.js v16 is still supported (as it very much should IMO, since there are existing downstreams still supporting it) so we ought to cover this version in tests, as long as it's still supported?
There was a problem hiding this comment.
Supported by whom? It's been EOL for almost a year: https://nodejs.org/en/about/previous-releases
There was a problem hiding this comment.
By @metamask/eth-json-rpc-infura, which depends on this package. So this will prevent upgrade there until the same breakage is made downstream?
Supported by whom? It's been EOL for almost a year: https://nodejs.org/en/about/previous-releases
Just noting that in general:
If you only rely on public free support options, yes, it's EoL from perspective of Node.js maintainers. However, many users receive their Node.js versions from other maintainers and can and will still run older versions by virtue of external vendor maintenance! This typically includes bugfixes and security updates.
Some examples of popular usage of even older Node versions:
- Debian bullseye is supporting Node.js v12 until 2026
- Ubuntu 22.04 is supporting Node.js v12 until 2027 for Standard users; supposedly until 2032 for Pro Support customers)
- This could also include Docker images based on the above dists, and vendors offering maintenance support for them
- Maybe more practically relevant for real-world usage would be Enterprise Linux like RHEL and SUSE EL.
Just because Node.js devs say "this version is now dead" does not make it so. Even if we could choose to align with their support cycle, it's not a given.
| @@ -7,29 +7,47 @@ jobs: | |||
| prepare: | |||
| name: Prepare | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node-version: [18.x, 20.x, 22.x] | |||
There was a problem hiding this comment.
| node-version: [18.x, 20.x, 22.x] | |
| node-version: [16.x, 18.x, 20.x, 22.x] |
| runs-on: ubuntu-latest | ||
| needs: | ||
| - prepare | ||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 22.x] |
There was a problem hiding this comment.
| node-version: [18.x, 20.x, 22.x] | |
| node-version: [16.x, 18.x, 20.x, 22.x] |
| runs-on: ubuntu-latest | ||
| needs: | ||
| - prepare | ||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 22.x] |
There was a problem hiding this comment.
| node-version: [18.x, 20.x, 22.x] | |
| node-version: [16.x, 18.x, 20.x, 22.x] |
Sire, I missed that that had just been created and merged prior. Just for visibility and future consideration: #156 (comment) |
Migrates from Yarn 3 to 4 and replaces
constraints.prowith JavaScript constraints viayarn.config.cjs. Migrating to Yarn 4 required a change to the Node / Yarn install flow in CI, which we solve by simply copypasting the workflows from the module template as of https://github.com/MetaMask/metamask-module-template/tree/570f6c2b80cb14fd61d5325131337401ae65c159.