Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide compatible types for v5.x #100

Closed
legobeat opened this issue Jul 25, 2023 · 2 comments · Fixed by #102
Closed

Provide compatible types for v5.x #100

legobeat opened this issue Jul 25, 2023 · 2 comments · Fixed by #102
Assignees
@Mrtenz

Comments

@legobeat
Copy link
Contributor

legobeat commented Jul 25, 2023 •
edited
Loading

Upgrading from 5.0.0 to 5.1.1 causes Typescript errors: https://github.com/MetaMask/json-rpc-engine/actions/runs/5660095486/job/15335070066?pr=147

MetaMask/json-rpc-engine#147 (review)

Would be great to fix the types so a new ^5.0.0 install works with code implemented towards 5.0.0.
@legobeat legobeat mentioned this issue Jul 25, 2023
Closed
@Mrtenz Mrtenz self-assigned this Jul 25, 2023
@legobeat
Copy link
Contributor Author

@Mrtenz Did you have a chance to look at this?

@Mrtenz
Copy link
Member

Mrtenz commented Aug 23, 2023

@Mrtenz Did you have a chance to look at this?

I don't really have the time to look into this at the moment. If you want to take a look, feel free!

This was referenced Aug 23, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mrtenz Mrtenz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

types: Make Data type-parameter optional in JsonRpcError legobeat/rpc-errors
2 participants
@Mrtenz @legobeat