Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the shared MetaMask ESLint config #2551

Open
rekmarks opened this issue Apr 19, 2021 · 3 comments
Open

Extend the shared MetaMask ESLint config #2551

rekmarks opened this issue Apr 19, 2021 · 3 comments
Labels
contributor experience An issue that impacts, or planned improvement to, the contributor experience. devtools

Comments

@rekmarks
Copy link
Member

rekmarks commented Apr 19, 2021

Mobile should extend:

  • @metamask/eslint-config, for all files
  • @metamask/eslint-config-jest, for tests

As discussed, rules can be disabled in the local ESLint config to make the overhead of migrating smaller.

For related work, see: MetaMask/eslint-config#170, MetaMask/eslint-config#171

This is a major change for dev experience (has no impact on users). After this change takes place, the engineers will have to code in a different way (before / after moment)

@rekmarks
Copy link
Member Author

When mobile does this, it's also a significant opportunity to get on the same Prettier config (although that change would make sense to do in a separate PR). If the mobile team feels strongly about its Prettier config, we should discuss what can be done to reconcile our differences of opinion.

Personally, I find 120 print width far too much.

@andrepimenta
Copy link
Member

I believe this is an important step to share more code and configurations with both products.

Context: https://consensys.slack.com/archives/G1L7H42BT/p1618866302118900

Started looking into this here: https://github.com/MetaMask/metamask-mobile/compare/improvement/shared-metamask-eslint-config

@mobularay
Copy link
Contributor

High impact for Engineers - need to align on timing as it changes the way code works. Engineers to discuss before working on this workl.

@brad-decker brad-decker added the contributor experience An issue that impacts, or planned improvement to, the contributor experience. label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor experience An issue that impacts, or planned improvement to, the contributor experience. devtools
Projects
None yet
Development

No branches or pull requests

4 participants