From 5dfafc2f9c3b78657b9c044e1156bef25aed979c Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Wed, 15 Jul 2020 18:58:32 -0300 Subject: [PATCH] Hide loading indication after `personal_sign` The loading indication had remained after successfully signing with `personal_sign`. This mistake was introduced accidentally in #8434. This is noticeable if you confirm the signature in the popup UI or fullscreen UI, as they remain open after signing. The notification UI closes after signing without waiting for this loading indicator to be removed. --- ui/app/store/actions.js | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/app/store/actions.js b/ui/app/store/actions.js index 5cdfaaecb206..5f92cdd98c7a 100644 --- a/ui/app/store/actions.js +++ b/ui/app/store/actions.js @@ -475,6 +475,7 @@ export function signPersonalMsg (msgData) { dispatch(displayWarning(error.message)) throw error } + dispatch(hideLoadingIndication()) dispatch(updateMetamaskState(newState)) dispatch(completedTx(msgData.metamaskId)) dispatch(closeCurrentNotificationWindow())