chore: update controllers as of core release `v244` #28781

cryptodev-2s · 2024-11-27T17:53:26Z

Description

This PR bumps the following packages:

@metamask/user-operation-controller to ^19.0.0
@metamask/ens-controller to ^15.0.0
@metamask/gas-fee-controller to ^22.0.1
@metamask/network-controller to ^22.0.2
@metamask/polling-controller to ^12.0.1
@metamask/select-network-controller to ^19.0.0

Related issues

Fixes: #28495

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-27T17:53:41Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-11-27T17:57:11Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	`0`	88.3 kB	metamaskbot
npm/@metamask/[email protected]	None	`+1`	227 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	134 kB	metamaskbot
npm/@metamask/[email protected]	network	`0`	485 kB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

cryptodev-2s · 2024-11-27T18:30:58Z

@metamaskbot update-policies

metamaskbot · 2024-11-27T18:40:46Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2024-11-27T19:14:19Z

Builds ready [c9178ad]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1648 ± 39 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1491	1772	1648	77	37
		domContentLoaded	1443	1758	1622	86	42
		load	1492	1773	1648	80	39
		domInteractive	23	64	35	13	6
		backgroundConnect	9	63	27	18	9
		firstReactRender	16	95	53	32	15
		getState	5	89	25	27	13
		initialActions	0	1	0	0	0
		loadScripts	1052	1315	1202	75	36
		setupStore	6	58	12	14	7
		uiStartup	1661	2359	1961	187	90

Bundle size diffs [🚀 Bundle size reduced!]

background: -29.86 KiB (-0.52%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

yarn.lock

…-19.0.0

metamaskbot · 2024-11-28T23:16:16Z

Builds ready [dccd430]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1903 ± 121 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	533	2729	1810	375	180
		domContentLoaded	1545	2710	1864	246	118
		load	1561	2736	1903	252	121
		domInteractive	24	72	32	12	6
		backgroundConnect	8	102	36	27	13
		firstReactRender	16	93	32	26	12
		getState	43	195	92	45	22
		initialActions	0	1	0	0	0
		loadScripts	1151	1713	1403	139	67
		setupStore	6	17	8	2	1
		uiStartup	1890	2947	2199	258	124

Bundle size diffs [🚀 Bundle size reduced!]

background: -29.86 KiB (-0.55%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

cryptodev-2s · 2024-11-28T23:57:19Z

@metamaskbot update-policies

metamaskbot · 2024-11-29T00:08:48Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

cryptodev-2s · 2024-11-29T00:26:42Z

package.json

@@ -244,6 +244,7 @@
    "@metamask/network-controller@npm:^17.0.0": "patch:@metamask/network-controller@npm%3A21.0.0#~/.yarn/patches/@metamask-network-controller-npm-21.0.0-559aa8e395.patch",
    "@metamask/network-controller@npm:^19.0.0": "patch:@metamask/network-controller@npm%3A21.0.0#~/.yarn/patches/@metamask-network-controller-npm-21.0.0-559aa8e395.patch",
    "@metamask/network-controller@npm:^20.0.0": "patch:@metamask/network-controller@npm%3A21.0.0#~/.yarn/patches/@metamask-network-controller-npm-21.0.0-559aa8e395.patch",
+    "@metamask/network-controller@npm:^21.0.0": "patch:@metamask/network-controller@npm%3A22.0.2#~/.yarn/patches/@metamask-network-controller-npm-22.0.2-6fc65c500a.patch",


still in use by @metamask/ppom-validator

.yarn/patches/@metamask-network-controller-npm-22.0.2-6fc65c500a.patch

package.json

Gudahtt

LGTM!

…-19.0.0

Gudahtt · 2024-11-29T16:08:01Z

Interesting, storybook failure

…ser-operatin-controller-19.0.0

cryptodev-2s added the team-wallet-framework label Nov 27, 2024

cryptodev-2s self-assigned this Nov 27, 2024

cryptodev-2s requested a review from a team as a code owner November 27, 2024 17:53

cryptodev-2s force-pushed the cryptodev2s/bump-user-operatin-controller-19.0.0 branch from a7fc418 to cfe48df Compare November 27, 2024 17:55

chore: bump @metamask/user-operation-controller to ^19.0.0

27a1948

cryptodev-2s force-pushed the cryptodev2s/bump-user-operatin-controller-19.0.0 branch from cfe48df to 27a1948 Compare November 27, 2024 18:30

Update LavaMoat policies

c9178ad

metamaskbot requested a review from a team as a code owner November 27, 2024 18:40

Gudahtt reviewed Nov 27, 2024

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

Merge branch 'develop' into cryptodev2s/bump-user-operatin-controller…

dccd430

…-19.0.0

chore: update dependencies to align with core release 244

e7e98a0

cryptodev-2s changed the title ~~chore: bump @metamask/user-operation-controller to ^19.0.0~~ chore: update controllers as of core release v244 Nov 28, 2024

Update LavaMoat policies

eca9f2c

cryptodev-2s commented Nov 29, 2024

View reviewed changes

cryptodev-2s requested a review from Gudahtt November 29, 2024 00:26

Gudahtt reviewed Nov 29, 2024

View reviewed changes

.yarn/patches/@metamask-network-controller-npm-22.0.2-6fc65c500a.patch Outdated Show resolved Hide resolved

Gudahtt reviewed Nov 29, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

cryptodev-2s added 2 commits November 29, 2024 01:48

fix: network controller patch

cb52f52

fix: lock file

7746123

Gudahtt reviewed Nov 29, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

fix: package json remove unused network controller resolution

ecf6ac8

Gudahtt previously approved these changes Nov 29, 2024

View reviewed changes

Merge branch 'develop' into cryptodev2s/bump-user-operatin-controller…

d7024b6

…-19.0.0

mikesposito previously approved these changes Nov 29, 2024

View reviewed changes

Merge branch 'develop' into cryptodev2s/bump-user-operatin-controller…

9a9a2f8

…-19.0.0

Merge remote-tracking branch 'origin/develop' into cryptodev2s/bump-u…

87d926c

…ser-operatin-controller-19.0.0

cryptodev-2s dismissed stale reviews from mikesposito and Gudahtt via 87d926c November 29, 2024 17:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update controllers as of core release `v244` #28781

chore: update controllers as of core release `v244` #28781

cryptodev-2s commented Nov 27, 2024 •

edited

Loading

github-actions bot commented Nov 27, 2024

socket-security bot commented Nov 27, 2024 •

edited

Loading

cryptodev-2s commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 28, 2024

cryptodev-2s commented Nov 28, 2024

metamaskbot commented Nov 29, 2024

cryptodev-2s Nov 29, 2024

Gudahtt left a comment

Gudahtt commented Nov 29, 2024

chore: update controllers as of core release v244 #28781

Are you sure you want to change the base?

chore: update controllers as of core release v244 #28781

Conversation

cryptodev-2s commented Nov 27, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 27, 2024

socket-security bot commented Nov 27, 2024 • edited Loading

cryptodev-2s commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 28, 2024

cryptodev-2s commented Nov 28, 2024

metamaskbot commented Nov 29, 2024

cryptodev-2s Nov 29, 2024

Choose a reason for hiding this comment

Gudahtt left a comment

Choose a reason for hiding this comment

Gudahtt commented Nov 29, 2024

chore: update controllers as of core release `v244` #28781

chore: update controllers as of core release `v244` #28781

cryptodev-2s commented Nov 27, 2024 •

edited

Loading

socket-security bot commented Nov 27, 2024 •

edited

Loading