chore: Update `@metamask/polling-controller` to v11 #28759

Gudahtt · 2024-11-27T05:20:10Z

Description

The @metamask/polling-controller package has been updated from v10 to v11. This update included several breaking changes to the polling controller mixins, impacting the BridgeController and BridgeStatusController. They have been updated to account for the changes. There should be no functional changes.

Changelog: https://github.com/MetaMask/core/blob/main/packages/polling-controller/CHANGELOG.md#1100

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Gudahtt · 2024-11-27T05:20:21Z

@metamaskbot update-policies

metamaskbot · 2024-11-27T05:30:18Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2024-11-27T06:07:16Z

Builds ready [bd7447a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1747 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1570	2184	1757	158	76
		domContentLoaded	1526	2104	1719	147	71
		load	1570	2119	1747	145	70
		domInteractive	25	82	39	18	9
		backgroundConnect	8	71	33	19	9
		firstReactRender	17	103	49	31	15
		getState	5	58	14	15	7
		initialActions	0	1	0	0	0
		loadScripts	1128	1609	1282	131	63
		setupStore	6	52	15	14	7
		uiStartup	1809	2395	2027	167	80

Bundle size diffs [🚀 Bundle size reduced!]

background: -16.88 KiB (-0.29%)
ui: 0 Bytes (0.00%)
common: -662 Bytes (-0.01%)

metamaskbot · 2024-11-27T13:39:16Z

Builds ready [d6cd3d9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1565 ± 28 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1487	1691	1573	60	29
		domContentLoaded	1441	1643	1530	56	27
		load	1453	1693	1565	59	28
		domInteractive	14	91	37	19	9
		backgroundConnect	12	85	37	20	10
		firstReactRender	15	96	40	31	15
		getState	6	92	29	30	15
		initialActions	0	1	0	0	0
		loadScripts	1043	1272	1134	55	26
		setupStore	6	84	23	26	12
		uiStartup	1625	2284	1851	199	95

Bundle size diffs [🚀 Bundle size reduced!]

background: -16.88 KiB (-0.29%)
ui: 0 Bytes (0.00%)
common: -662 Bytes (-0.01%)

The `@metamask/polling-controller` package has been updated from v10 to v11. This update included several breaking changes to the polling controller mixins, impacting the `BridgeController` and `BridgeStatusController`. They have been updated to account for the changes. There should be no functional changes. Changelog: https://github.com/MetaMask/core/blob/main/packages/polling-controller/CHANGELOG.md#1100

metamaskbot · 2024-11-27T16:13:41Z

Builds ready [830db15]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1797 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	460	2246	1749	356	171
		domContentLoaded	1484	2135	1764	188	90
		load	1497	2165	1797	191	91
		domInteractive	23	60	37	11	5
		backgroundConnect	9	97	41	23	11
		firstReactRender	16	179	50	43	21
		getState	6	67	24	22	11
		initialActions	0	0	0	0	0
		loadScripts	1051	1659	1311	161	77
		setupStore	6	87	23	27	13
		uiStartup	1642	2672	2118	286	137

Bundle size diffs [🚀 Bundle size reduced!]

background: -16.88 KiB (-0.29%)
ui: 0 Bytes (0.00%)
common: -662 Bytes (-0.01%)

The mocks are setup incorrectly, so the `networkClientId` is not a string as it should be. Really we should fix the mocks, but this can be fixed later and is a pre-existing problem.

metamaskbot · 2024-11-27T17:09:59Z

Builds ready [fe985db]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1702 ± 87 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	297	2213	1632	352	169
		domContentLoaded	1475	2195	1671	176	85
		load	1483	2240	1702	181	87
		domInteractive	24	75	41	17	8
		backgroundConnect	7	99	29	25	12
		firstReactRender	15	68	36	20	9
		getState	4	77	26	23	11
		initialActions	0	1	0	0	0
		loadScripts	1060	1533	1233	127	61
		setupStore	6	70	13	15	7
		uiStartup	1621	2422	1909	201	96

Bundle size diffs [🚀 Bundle size reduced!]

background: -16.88 KiB (-0.29%)
ui: 0 Bytes (0.00%)
common: -662 Bytes (-0.01%)

mcmire

Makes sense!

cryptodev-2s

LGTM!

metamaskbot added the team-wallet-framework label Nov 27, 2024

Gudahtt force-pushed the update-polling-controller-v11 branch from bd7447a to d6cd3d9 Compare November 27, 2024 13:07

Gudahtt and others added 3 commits November 27, 2024 12:09

Update LavaMoat policies

c51cc9d

Fix tests

830db15

Gudahtt force-pushed the update-polling-controller-v11 branch from 609d6c4 to 830db15 Compare November 27, 2024 15:39

Fix tests again

fe985db

The mocks are setup incorrectly, so the `networkClientId` is not a string as it should be. Really we should fix the mocks, but this can be fixed later and is a pre-existing problem.

Gudahtt force-pushed the update-polling-controller-v11 branch from bd0bdeb to fe985db Compare November 27, 2024 16:35

Gudahtt marked this pull request as ready for review November 27, 2024 17:04

Gudahtt requested review from a team as code owners November 27, 2024 17:04

Gudahtt added the team-bridge label Nov 27, 2024

mcmire approved these changes Nov 27, 2024

View reviewed changes

cryptodev-2s approved these changes Nov 27, 2024

View reviewed changes

micaelae approved these changes Nov 27, 2024

View reviewed changes

Gudahtt added this pull request to the merge queue Nov 27, 2024

Merged via the queue into develop with commit 86e616b Nov 27, 2024
77 checks passed

Gudahtt deleted the update-polling-controller-v11 branch November 27, 2024 18:17

github-actions bot locked and limited conversation to collaborators Nov 27, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update `@metamask/polling-controller` to v11 #28759

chore: Update `@metamask/polling-controller` to v11 #28759

Gudahtt commented Nov 27, 2024 •

edited by github-actions bot

Loading

Gudahtt commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

mcmire left a comment

cryptodev-2s left a comment

chore: Update @metamask/polling-controller to v11 #28759

chore: Update @metamask/polling-controller to v11 #28759

Conversation

Gudahtt commented Nov 27, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Gudahtt commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

metamaskbot commented Nov 27, 2024

mcmire left a comment

Choose a reason for hiding this comment

cryptodev-2s left a comment

Choose a reason for hiding this comment

chore: Update `@metamask/polling-controller` to v11 #28759

chore: Update `@metamask/polling-controller` to v11 #28759

Gudahtt commented Nov 27, 2024 •

edited by github-actions bot

Loading