Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump @metamask/eth-json-rpc-middleware to v15.0.0 #28756

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 27, 2024

Description

Bump @metamask/eth-json-rpc-middlware from v14.0.2 to v15.0.0. This eliminates some older copies of libraries from our dependency tree, and aligns the json-rpc-engine and rpc-errors versions with the rest of our middleware stack.

This release also drops support for eth_sign, but that has been removed from the extension already.

Changelog: https://github.com/MetaMask/eth-json-rpc-middleware/blob/main/CHANGELOG.md#1500

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt

This comment was marked as resolved.

Copy link

socket-security bot commented Nov 27, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 27, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

Builds ready [d5668b8]
Page Load Metrics (1840 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24020691436653314
domContentLoaded15642088180615072
load15702119184016077
domInteractive208839178
backgroundConnect8129343015
firstReactRender167729168
getState55621199
initialActions01000
loadScripts11051574131912359
setupStore668232311
uiStartup17932363205917182
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -23.52 KiB (-0.40%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt force-pushed the bump-eth-json-rpc-middleware-14.0.2 branch from c3f476b to 05e4ba5 Compare November 27, 2024 13:05
Base automatically changed from bump-eth-json-rpc-middleware-14.0.2 to develop November 27, 2024 16:06
Gudahtt and others added 2 commits November 27, 2024 13:41
Bump `@metamask/eth-json-rpc-middlware` from v14.0.2 to v15.0.0. This
eliminates some older copies of libraries from our dependency tree, and
aligns the `json-rpc-engine` and `rpc-errors` versions with the rest of
our middleware stack.

This release also drops support for `eth_sign`, but that has been
removed from the extension already.

Changelog: https://github.com/MetaMask/eth-json-rpc-middleware/blob/main/CHANGELOG.md#1500
@Gudahtt Gudahtt force-pushed the bump-eth-json-rpc-middleware-15.0.0 branch from d5668b8 to fd85354 Compare November 27, 2024 17:12
@metamaskbot
Copy link
Collaborator

Builds ready [fd85354]
Page Load Metrics (1648 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37320001589319153
domContentLoaded14681924162414369
load14841989164814971
domInteractive247540199
backgroundConnect76431199
firstReactRender1672352311
getState56111126
initialActions01000
loadScripts10591430119511957
setupStore65814168
uiStartup16462169182916278
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -23.52 KiB (-0.40%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Gudahtt Gudahtt marked this pull request as ready for review November 27, 2024 19:23
@Gudahtt Gudahtt requested review from a team as code owners November 27, 2024 19:23
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Gudahtt Gudahtt added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit be33175 Nov 27, 2024
75 checks passed
@Gudahtt Gudahtt deleted the bump-eth-json-rpc-middleware-15.0.0 branch November 27, 2024 22:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants