feat: PortfolioView: Add feature flag check for polling intervals #28501

darkwing · 2024-11-15T18:31:01Z

Description

Adds a remote endpoint check to see if the remote API wants us to update the number of seconds between polling intervals for balances.

Related issues

Fixes:

Manual testing steps

Open the extension
See the network request being made in the Networks devtools panel
Change conditional in response to if (true) { and hardcode a pollInterval value
See this.tokenBalancesController.setIntervalLength successfully called.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-15T18:31:14Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

app/scripts/metamask-controller.js

metamaskbot · 2024-11-15T19:16:31Z

Builds ready [4640516]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1818 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1685	2125	1820	112	54
		domContentLoaded	1661	2077	1795	105	50
		load	1686	2131	1818	114	55
		domInteractive	30	80	44	13	6
		backgroundConnect	10	86	28	23	11
		firstReactRender	67	206	102	26	12
		getState	4	53	15	17	8
		initialActions	0	1	0	0	0
		loadScripts	1201	1518	1318	87	42
		setupStore	5	63	9	12	6
		uiStartup	1850	2387	2028	147	71

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 666 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-15T22:16:06Z

Builds ready [cb82a96]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1862 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1670	2221	1864	136	65
		domContentLoaded	1621	2138	1829	124	60
		load	1663	2225	1862	135	65
		domInteractive	15	176	48	34	16
		backgroundConnect	8	88	33	25	12
		firstReactRender	48	204	98	60	29
		getState	48	201	105	39	19
		initialActions	0	1	0	0	0
		loadScripts	1176	1606	1359	102	49
		setupStore	6	79	14	21	10
		uiStartup	1905	2784	2231	236	113

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 666 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-16T01:31:11Z

Builds ready [cbc318f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1830 ± 90 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	308	2330	1766	380	182
		domContentLoaded	1610	2317	1807	178	85
		load	1643	2333	1830	187	90
		domInteractive	26	246	59	54	26
		backgroundConnect	9	120	25	25	12
		firstReactRender	43	102	66	20	9
		getState	38	110	86	20	10
		initialActions	0	1	0	0	0
		loadScripts	1201	1786	1369	151	72
		setupStore	6	53	9	10	5
		uiStartup	1867	2668	2089	229	110

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 666 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-19T17:46:14Z

Builds ready [93887cf]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1985 ± 84 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	260	2559	1912	421	202
		domContentLoaded	1685	2415	1947	163	78
		load	1729	2511	1985	174	84
		domInteractive	27	267	51	50	24
		backgroundConnect	10	89	35	24	11
		firstReactRender	48	164	80	24	11
		getState	41	132	83	25	12
		initialActions	0	1	0	0	0
		loadScripts	1229	1851	1465	138	66
		setupStore	6	51	12	12	6
		uiStartup	1968	3084	2267	227	109

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 666 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

darkwing · 2024-11-19T17:57:48Z

Feature flag implementation here: https://github.com/consensys-vertical-apps/va-mmcx-swap-api/pull/221

metamaskbot · 2024-11-19T18:35:53Z

Builds ready [b4ba8d2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2194 ± 150 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	367	2581	1859	601	288
		domContentLoaded	1764	2874	2156	306	147
		load	1785	2886	2194	312	150
		domInteractive	29	208	61	40	19
		backgroundConnect	12	88	35	22	11
		firstReactRender	52	307	152	92	44
		getState	57	208	128	51	25
		initialActions	0	1	0	0	0
		loadScripts	1278	2179	1619	257	123
		setupStore	6	49	12	10	5
		uiStartup	2045	3477	2688	412	198

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 692 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-19T22:57:37Z

Builds ready [323e8df]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2157 ± 180 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	417	3164	2004	634	305
		domContentLoaded	1668	3068	2129	375	180
		load	1676	3079	2157	375	180
		domInteractive	28	244	59	47	23
		backgroundConnect	9	74	27	22	11
		firstReactRender	46	325	106	77	37
		getState	44	181	109	36	17
		initialActions	0	1	0	0	0
		loadScripts	1223	2519	1637	334	161
		setupStore	6	87	16	24	11
		uiStartup	1905	3443	2546	407	195

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 576 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-26T16:23:15Z

Builds ready [4be5539]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1733 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	356	2109	1671	334	161
		domContentLoaded	1543	2096	1703	149	72
		load	1554	2108	1733	146	70
		domInteractive	24	71	38	15	7
		backgroundConnect	6	72	29	23	11
		firstReactRender	15	99	37	27	13
		getState	5	75	18	20	9
		initialActions	0	1	0	0	0
		loadScripts	1115	1616	1251	136	65
		setupStore	6	66	17	20	10
		uiStartup	1762	2684	1943	225	108

metamaskbot · 2024-11-26T19:12:58Z

Builds ready [2514209]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1748 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	238	2039	1609	435	209
		domContentLoaded	1479	2025	1722	132	63
		load	1492	2040	1748	134	64
		domInteractive	21	105	36	19	9
		backgroundConnect	7	64	29	17	8
		firstReactRender	17	80	48	23	11
		getState	4	56	13	12	6
		initialActions	0	1	0	0	0
		loadScripts	1083	1496	1273	108	52
		setupStore	6	53	15	16	8
		uiStartup	1675	2369	1952	157	76

gambinish · 2024-11-26T20:20:42Z

We still planning to include this in the release? Or are we deciding to table this in favor of LaunchDarkly?

darkwing · 2024-11-26T21:59:24Z

This needs to go into release.

darkwing requested a review from a team as a code owner November 15, 2024 18:31

metamaskbot added the team-wallet-ux label Nov 15, 2024

darkwing force-pushed the portfolio-view-feature-flag branch from 91dc03e to 4640516 Compare November 15, 2024 18:41

bergeron reviewed Nov 15, 2024

View reviewed changes

app/scripts/metamask-controller.js Outdated Show resolved Hide resolved

darkwing force-pushed the portfolio-view-feature-flag branch from cbc318f to 02ec515 Compare November 16, 2024 01:48

darkwing changed the title ~~PortfolioView: Add feature flag check for paused networks and intervals~~ feat: PortfolioView: Add feature flag check for paused networks and intervals Nov 16, 2024

darkwing force-pushed the portfolio-view-feature-flag branch from 02ec515 to 93887cf Compare November 19, 2024 17:11

darkwing changed the title ~~feat: PortfolioView: Add feature flag check for paused networks and intervals~~ feat: PortfolioView: Add feature flag check for polling intervals Nov 25, 2024

darkwing force-pushed the portfolio-view-feature-flag branch 2 times, most recently from a0e28aa to 3ea34a9 Compare November 25, 2024 19:19

darkwing requested a review from a team as a code owner November 25, 2024 19:19

darkwing force-pushed the portfolio-view-feature-flag branch from 3ea34a9 to 13b2230 Compare November 26, 2024 14:54

darkwing added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Nov 26, 2024

darkwing force-pushed the portfolio-view-feature-flag branch from 13b2230 to 7f3faa9 Compare November 26, 2024 15:17

PortfolioView: Add feature flag check for paused networks and intervals

4be5539

darkwing force-pushed the portfolio-view-feature-flag branch from 7f3faa9 to 4be5539 Compare November 26, 2024 15:34

Add tests

2514209

gambinish approved these changes Nov 26, 2024

View reviewed changes

salimtb approved these changes Nov 27, 2024

View reviewed changes

gambinish added this pull request to the merge queue Nov 27, 2024

Merged via the queue into develop with commit 068c456 Nov 27, 2024
75 checks passed

gambinish deleted the portfolio-view-feature-flag branch November 27, 2024 16:39

github-actions bot locked and limited conversation to collaborators Nov 27, 2024

metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: PortfolioView: Add feature flag check for polling intervals #28501

feat: PortfolioView: Add feature flag check for polling intervals #28501

darkwing commented Nov 15, 2024 •

edited

Loading

github-actions bot commented Nov 15, 2024

metamaskbot commented Nov 15, 2024

metamaskbot commented Nov 15, 2024

metamaskbot commented Nov 16, 2024

metamaskbot commented Nov 19, 2024

darkwing commented Nov 19, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

gambinish commented Nov 26, 2024

darkwing commented Nov 26, 2024

feat: PortfolioView: Add feature flag check for polling intervals #28501

feat: PortfolioView: Add feature flag check for polling intervals #28501

Conversation

darkwing commented Nov 15, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 15, 2024

metamaskbot commented Nov 15, 2024

metamaskbot commented Nov 15, 2024

metamaskbot commented Nov 16, 2024

metamaskbot commented Nov 19, 2024

darkwing commented Nov 19, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

gambinish commented Nov 26, 2024

darkwing commented Nov 26, 2024

darkwing commented Nov 15, 2024 •

edited

Loading