Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Phishing page metrics #28364

Merged
merged 10 commits into from
Nov 27, 2024
Merged

fix: Phishing page metrics #28364

merged 10 commits into from
Nov 27, 2024

Conversation

mindofmar
Copy link
Contributor

@mindofmar mindofmar commented Nov 7, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/orgs/MetaMask/projects/103/views/1?pane=issue&itemId=86413189

Manual testing steps

See Issue attached in Related Issues.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-product-safety Push issues to Product Safety team label Nov 7, 2024
@mindofmar
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 7, 2024
@mindofmar mindofmar changed the title Fix: Phishing page metrics fix: Phishing page metrics Nov 7, 2024
@mindofmar mindofmar marked this pull request as ready for review November 7, 2024 18:52
@mindofmar mindofmar requested a review from a team as a code owner November 7, 2024 18:52
@metamaskbot
Copy link
Collaborator

Builds ready [e634bfc]
Page Load Metrics (2184 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25526142103462222
domContentLoaded18912532215217684
load19502540218417785
domInteractive30110532010
backgroundConnect1076362110
firstReactRender563001455728
getState86023199
initialActions00000
loadScripts13571927160214168
setupStore65814147
uiStartup216128802466215103
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 90 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

app/scripts/background.js Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [5232bbd]
Page Load Metrics (1740 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15142001174714771
domContentLoaded14931989171413264
load15042004174013866
domInteractive207336178
backgroundConnect981282010
firstReactRender1670372110
getState576192110
initialActions00000
loadScripts10881582127512459
setupStore615821
uiStartup16942221192215173
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 72 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

cryptotavares
cryptotavares previously approved these changes Nov 27, 2024
Copy link
Contributor

@AugmentedMode AugmentedMode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [b05e1e3]
Page Load Metrics (1717 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14782144171418689
domContentLoaded14642136167517986
load14822149171718890
domInteractive229039199
backgroundConnect9200424321
firstReactRender1695412914
getState498262914
initialActions01000
loadScripts10271590121715072
setupStore66416189
uiStartup163825691932247119
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 63 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@mindofmar mindofmar added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit 080d005 Nov 27, 2024
75 checks passed
@mindofmar mindofmar deleted the fix/phishing-page-metrics branch November 27, 2024 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-product-safety Push issues to Product Safety team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants