fix: Fix snaps permission connection for CHAIN_PERMISSIONS feature flag

[jiexi]

Description

Recent permission flow changes introduced behind the CHAIN_PERMISSIONS feature flag have broken permission connection for Snaps. This PR fixes it by removing an incorrect forced route direct in the permission connection component.

Related issues

Fixes: #26635

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[adonesky1]

could you briefly explain why !permissionsRequest?.diff isn't necessary anymore?

[jiexi]

metamask-extension/ui/pages/permissions-connect/permissions-connect.component.js

Lines 152 to 158 in ed3311a

	if (
	permissionsRequest?.diff?.permissionDiffMap?.[
	PermissionNames.permittedChains
	]
	) {
	history.replace(confirmPermissionPath);
	}

This guard was ensuring that the incremental request for permittedChains goes to the confirmPermissionPath route in the first place. Now the new ConnectPage component has been moved out of the confirmPermissionPath and into the connectPath route.

I recommend viewing the file as a whole as the github diff makes it a little bit difficult to notice this change

[sonarqubecloud]

Quality Gate failed

Failed conditions
16.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[metamaskbot]

Builds ready [ed3311a]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6
  • common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1792 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	265	2325	1581	567	272
		domContentLoaded	1442	2206	1763	152	73
		load	1449	2330	1792	173	83
		domInteractive	18	68	35	14	7

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 106 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[adonesky1]

LGTM